Added the 404 page pattern #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2017 15:57
re-write of documentation and the example
gavinwye
force-pushed
the
SDT-678-404-pages
branch
from
2c0cb2a
to
c7296df
Compare
|
I'm not sure if we need to show the HTML example in a pattern |
rpowis
suggested changes
Oct 24, 2017
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
| * Replace the component library with a new design pattern library [#822](https://github.com/hmrc/assets-frontend/pull/822) | |||
| * Add header component to the new design system | |||
| * Use macros for example and markup rendering in README.md | |||
| * Added a 404 page pattern | |||
There was a problem hiding this comment.
This needs a link to this PR. Look at previous entries for how to add one.
https://github.com/alphagov/govuk_elements/blob/master/assets/sass/elements/_panels.scss This is needed to make the reveal in the 404 look correct
# Conflicts: # CHANGELOG.md # assets/patterns/README.md
7 tasks
rpowis
approved these changes
Oct 24, 2017
hmrc-web-operations
pushed a commit
that referenced
this pull request
Oct 24, 2017
generated from commit b0707f7
hmrc-web-operations
pushed a commit
that referenced
this pull request
Oct 25, 2017
generated from commit b0707f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to document a 404 page in the design system so users know how to display a message for a page not found.
Problem
Users do not know how to create a 404 page in a service.
Solution
I have added documentation, a rendered example and html snippet in the design system for users to reference when building a service.