SDT-644 design pattern library #822
Conversation
|
This PR relies on an update to the component-library-template. I'll add the link here when it's open. |
rpowis
force-pushed
the
SDT-644-design-pattern-library
branch
from
badbb76
to
5b46cd3
Compare
|
Here's the PR for the template hmrc/component-library-template#37 |
rpowis
force-pushed
the
SDT-644-design-pattern-library
branch
from
5b46cd3
to
5cbd64b
Compare
| @@ -1,7 +1,7 @@ | |||
| var test = require('tape') | |||
| var prepareAssetPaths = require('../util/component-library/prepareAssetPaths') | |||
|
|
|||
| test('prepareAssetPaths - Creates links from an array of css paths', function (t) { | |||
| test.skip('prepareAssetPaths - Creates links from an array of css paths', function (t) { | |||
There was a problem hiding this comment.
Why are these skipped?
There was a problem hiding this comment.
Good catch. prepareAssetPaths doesn't exist anymore so we can scrap these tests altogether.
There was a problem hiding this comment.
It does exist, my bad. It's part of the component library, not the design pattern library
| var mkdirp = require('mkdirp') | ||
|
|
||
| var writeFiles = function (config, files) { | ||
| if (!config.dest) { |
There was a problem hiding this comment.
Shouldn't we check whether config is defined?
| throw new Error('Handlebars helpers directory must be a string or an array.') | ||
| } | ||
|
|
||
| if (typeof helpersDirectoryPaths === 'string') { |
There was a problem hiding this comment.
Please use the isString variable
| }) | ||
| }) | ||
| }) | ||
| .then((stuff) => { |
There was a problem hiding this comment.
Not sure about the variable name :)
gulpfile.js/tasks/pattern-library.js
Outdated
|
|
||
| // gulp.task('pattern-library', ['clean-pattern-library', 'sass', 'images', 'browserify'], function () { | ||
| gulp.task('pattern-library', ['clean-pattern-library'], function () { | ||
| var env = global.runmode |
There was a problem hiding this comment.
Is runmode always defined?
| ) | ||
| }) | ||
|
|
||
| compileTemplate(existingTemplate) |
There was a problem hiding this comment.
Not sure about this test
There was a problem hiding this comment.
It was to make sure that we're returning the result of Handlebars.compile without coupling the test to Handlebars, but maybe we should just mock the dependency instead.
| var path = require('path') | ||
|
|
||
| var addFileType = function (config, files) { | ||
| if (!Array.isArray(config.src)) { |
There was a problem hiding this comment.
Do we have config at this point for sure? if so should we rely on a previous step to verify?
rpowis
force-pushed
the
SDT-644-design-pattern-library
branch
2 times, most recently
from
a8d65da
to
28a4760
Compare
Also disable the tests.
csabascript
force-pushed
the
SDT-644-design-pattern-library
branch
from
28a4760
to
f8d7495
Compare
…rary generated from commit fe5de19
This PR builds a Design Systerm (based on the GOV.UK Design System) from our components and patterns.
Problem
Our component library isn't aligned with GOV.UK and has a lot of cruft in there that should be deprecated.
Example Screenshot
Solution
Generate a new Design System that only consists of the components and patterns that adhere to the new directory structure.
Example Screenshot