Accessible page heading #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current design pattern seems like it could be built a little better. The page title reads "Contacting you — GOV.UK elements", which isn't how the `h1` reads. Having a `span` in the `h1` gives differing results, depending on the assistive technology used. This new version splits the page name (`h1`) and the section name (`p`) – which are now in the correct source order – and then positions the section name above with CSS. This keeps the pattern visually identical, but brings added accessibility wins. The user can skip to the first header and they'll hear _just_ the page header. If they then key through the page, they'll hear which section they're in.
|
Good stuff. Thanks @philsherry. I've updated from master for you 👍 |
hmrc-web-operations
pushed a commit
that referenced
this pull request
Sep 29, 2017
generated from commit 0c414e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current design pattern seems like it could be built a little better.
The page title reads "Contacting you — GOV.UK elements",
which isn't how the
h1reads. Having aspanin theh1givesdiffering results, depending on the assistive technology used.
Example Screenshot
Solution
This new version splits the page name (
h1) and the section name (p) –which are now in the correct source order – and then positions the section
name above with CSS. This keeps the pattern visually identical, but brings
added accessibility wins.
The user can skip to the first header and they'll hear just the page header. If they then key through the page, they'll hear which section they're in.
Example Screenshot