Rerun sass task in prod mode for CI #804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the refactoring of gulp tasks, the sass job doesn't build the production stylesheets during the
build
job.Because the sass task is being run as a dependency of the
test
task, theglobal.runmode
is set as the defaultdev
. Due to this, the sass task doesn't minify the styles or put them in theassets/dist
directory ready to be zipped and deployed.Example Screenshot
Solution
By explicitly calling the
sass
task as a step in thebuild
task it picks up theglobal.runmode = 'prod'
setting and builds the styles for production.Example Screenshot
Caveats
The
sass
task is being run twice as it's still a dependency of thetest
task. Ideally, thesass
task would only be run once and then a separate minification step would be run for production.That hasn't been done for this change as we need to get a fix out for missing styles quickly and introducing a new minification library could produce different output to the original
sass
job.