Repository navigation
Fix/issue 577 app shell router boundaries - #592
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughapps/server に vite-plugin-mkcert を追加し、vite.config.ts へ実行時モジュールロードと oRPC 用開発ミドルウェアを追加。あわせて複数ファイルで import 順序、ログ呼び出し、テストモック、型定義の表記が整えられています。 ChangesVite dev サーバ拡張
Estimated code review effort: 3 (Moderate) | ~25 minutes 整形変更
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant ViteDevServer
participant devOrpcNodeMiddlewarePlugin
participant bootstrap
participant RPCHandler
Browser->>ViteDevServer: /api/rpc リクエスト
ViteDevServer->>devOrpcNodeMiddlewarePlugin: ミドルウェア実行
devOrpcNodeMiddlewarePlugin->>bootstrap: bootstrap() 呼び出し
devOrpcNodeMiddlewarePlugin->>RPCHandler: handler.handle 呼び出し
RPCHandler-->>devOrpcNodeMiddlewarePlugin: matched 結果
alt matched が true
devOrpcNodeMiddlewarePlugin-->>Browser: RPC 応答
else matched が false
devOrpcNodeMiddlewarePlugin->>ViteDevServer: next()
end
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/server/vite.config.ts`:
- Around line 61-75: The RPC middleware in the Vite config should use a strict
path boundary check so it matches only the intended /api/rpc route and not
prefixes like /api/rpcfoo. Update the request guard in the middleware around
handler.handle to verify the next path segment boundary, and when handler.handle
returns unmatched, explicitly send a 404 response instead of calling next() so
it behaves consistently with rpc.$.ts. Use the existing bootstrap and
handler.handle flow as the entry point for the fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 33d408e8-3474-4d07-8876-3a7774ef00b6
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
apps/server/package.jsonapps/server/src/application/services/media-source-service.tsapps/server/src/infrastructure/ai/rust-ai-client.tsapps/server/src/infrastructure/jobs/file-watcher-manager.tsapps/server/src/tests/unit/application/services/maintenance-service.test.tsapps/server/src/tests/unit/infrastructure/jobs/job-worker.test.tsapps/server/vite.config.tsapps/tauri/src/components/media/media-sidebar/media-sidebar-content.tsxpackages/core/src/domain/search/logic.tspackages/ui/src/hooks/use-manager-page.tspackages/ui/src/media-sidebar-content.tsxpackages/ui/src/media-sidebar.tsx
💤 Files with no reviewable changes (1)
- packages/ui/src/hooks/use-manager-page.ts
Summary by CodeRabbit