NFDIV-4344: Add logic to prevent submission with missing required fields #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamg-hmcts
reviewed
Feb 11, 2025
| req.session.userCase.applicant1ConfirmInformationStillCorrect !== YesOrNo.YES && | ||
| isEmpty(req.session.userCase.applicant1ReasonInformationNotCorrect) | ||
| ) { | ||
| res.redirect(REVIEW_YOUR_JOINT_APPLICATION); |
There was a problem hiding this comment.
Do we need to use a different URL for applicant 1 in sole cases, as they won't have REVIEW_YOUR_JOINT_APPLICATION?
adamg-hmcts
approved these changes
Feb 11, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has been stalled for 2 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add logic to prevent submission with missing required fields
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4344
Before merging a pull request make sure that:
If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:
Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.