DMP-4905 Close Identified Datamodel Gaps #2714
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
madjava,
ciaranca and
JakeM-Kainos
and removed request for
a team
Plan Result (stg)
Change Result (Click me) # module.armsa.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/darts-stg-rg/providers/Microsoft.Storage/storageAccounts/dartsarmstg"
name = "dartsarmstg"
tags = {
"application" = "darts"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/darts-api.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#darts-devs"
"environment" = "staging"
"managedBy" = "Darts Modernisation"
}
# (96 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
# module.postgresql_flexible.azurerm_log_analytics_workspace.pgsql_log_analytics_workspace[0] will be updated in-place
~ resource "azurerm_log_analytics_workspace" "pgsql_log_analytics_workspace" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/darts-stg-rg/providers/Microsoft.OperationalInsights/workspaces/darts-api-stg-workspace"
name = "darts-api-stg-workspace"
~ tags = {
- "application" = "darts" -> null
- "builtFrom" = "https://github.com/HMCTS/darts-shared-infrastructure.git" -> null
- "businessArea" = "Cross-Cutting" -> null
- "environment" = "staging" -> null
}
# (15 unchanged attributes hidden)
}
# module.postgresql_flexible.azurerm_monitor_diagnostic_setting.pgsql_diag[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "pgsql_diag" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/darts-stg-rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/darts-api-stg|darts-api-stg-to-log-analytics"
name = "darts-api-stg-to-log-analytics"
# (5 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (6 unchanged blocks hidden)
}
# module.postgresql_flexible.azurerm_postgresql_flexible_server.pgsql_server will be updated in-place
~ resource "azurerm_postgresql_flexible_server" "pgsql_server" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/darts-stg-rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/darts-api-stg"
name = "darts-api-stg"
~ storage_mb = 524288 -> 65536
tags = {
"application" = "darts"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/darts-api.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#darts-devs"
"environment" = "staging"
"managedBy" = "Darts Modernisation"
}
# (19 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # module.armsa.azurerm_storage_account.storage_account will be updated in-place
~ resource "azurerm_storage_account" "storage_account" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/darts-prod-rg/providers/Microsoft.Storage/storageAccounts/dartsarmprod"
name = "dartsarmprod"
tags = {
"application" = "darts"
"builtFrom" = "https://github.com/HMCTS/darts-api.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#darts-devs"
"environment" = "production"
"managedBy" = "Darts Modernisation"
}
# (96 unchanged attributes hidden)
+ network_rules {
+ bypass = [
+ "AzureServices",
]
+ default_action = "Allow"
}
# (3 unchanged blocks hidden)
}
# module.postgresql_flexible.azurerm_log_analytics_workspace.pgsql_log_analytics_workspace[0] will be updated in-place
~ resource "azurerm_log_analytics_workspace" "pgsql_log_analytics_workspace" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/darts-prod-rg/providers/Microsoft.OperationalInsights/workspaces/darts-api-prod-workspace"
name = "darts-api-prod-workspace"
~ tags = {
- "application" = "darts" -> null
- "builtFrom" = "https://github.com/HMCTS/darts-shared-infrastructure.git" -> null
- "businessArea" = "Cross-Cutting" -> null
- "environment" = "production" -> null
}
# (15 unchanged attributes hidden)
}
# module.postgresql_flexible.azurerm_monitor_diagnostic_setting.pgsql_diag[0] will be updated in-place
~ resource "azurerm_monitor_diagnostic_setting" "pgsql_diag" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/darts-prod-rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/darts-api-prod|darts-api-prod-to-log-analytics"
name = "darts-api-prod-to-log-analytics"
# (5 unchanged attributes hidden)
- metric {
- category = "AllMetrics" -> null
- enabled = false -> null
- retention_policy {
- days = 0 -> null
- enabled = false -> null
}
}
# (6 unchanged blocks hidden)
}
# module.postgresql_flexible.azurerm_postgresql_flexible_server.pgsql_server will be updated in-place
~ resource "azurerm_postgresql_flexible_server" "pgsql_server" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/darts-prod-rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/darts-api-prod"
name = "darts-api-prod"
~ storage_mb = 1048576 -> 65536
tags = {
"application" = "darts"
"builtFrom" = "https://github.com/HMCTS/darts-api.git"
"businessArea" = "Cross-Cutting"
"contactSlackChannel" = "#darts-devs"
"environment" = "production"
"managedBy" = "Darts Modernisation"
}
# (19 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. |
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2714
labels
chrisbellingham-hmcts
approved these changes
Mar 14, 2025
karen-hedges
force-pushed
the
DMP-4905-CloseIdentifiedDatamodelGaps
branch
from
fa65b59 to
177eef5
Compare
davet1985
reviewed
Mar 14, 2025
karen-hedges
force-pushed
the
DMP-4905-CloseIdentifiedDatamodelGaps
branch
from
70eb4ec to
925bf1c
Compare
renamed |
davet1985
approved these changes
Mar 14, 2025
karen-hedges
force-pushed
the
DMP-4905-CloseIdentifiedDatamodelGaps
branch
2 times, most recently
from
a3d1ac2 to
6e1ccf4
Compare
karen-hedges
force-pushed
the
DMP-4905-CloseIdentifiedDatamodelGaps
branch
from
6e1ccf4 to
a8e66f9
Compare
Updated the following: Drop column object_state_record.loaded_to_osr_ts Drop the existing default on case_overflow.last_modified_ts
Updated the following: Drop column object_state_record.loaded_to_osr_ts Drop the existing default on case_overflow.last_modified_ts
karen-hedges
force-pushed
the
DMP-4905-CloseIdentifiedDatamodelGaps
branch
from
a8e66f9 to
a48eb9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4905
Change description
Updated the following:
Drop column object_state_record.loaded_to_osr_ts
Drop the existing default on case_overflow.last_modified_ts
Does this PR introduce a breaking change? (check one with "x")