Dmp 4633 resolve sonar issues6 #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2704
labels
karen-hedges
requested review from
davet1985,
jackmaloney,
cakeben,
Abhivan,
endakelly and
Tyler-35
and removed request for
a team
karen-hedges
force-pushed
the
DMP-4633-ResolveSonarIssues6
branch
from
584ecae to
f4e36b3
Compare
hemantasharma1129
approved these changes
Mar 13, 2025
chrisbellingham-hmcts
approved these changes
Mar 13, 2025
fixed sonar comlaints: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. Change this instance-reference to a static reference
fixed sonar comlaints: Rename this variable to not match a restricted identifier.
fixed sonar comlaints: Use java.nio.file.Files#delete here for better messages on error conditions
karen-hedges
force-pushed
the
DMP-4633-ResolveSonarIssues6
branch
from
467b9f8 to
3a96ce9
Compare
karen-hedges
added a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4633
Change description
Fixed sonar complaints:
Does this PR introduce a breaking change? (check one with "x")