Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-4753: Handle NEWCASE event type #2694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Summary of Git Diff

The provided Git Diff reflects changes made to two files in the project: CaseController.java and cases.yaml. The main modifications include the removal of a method from the CaseController class and the deletion of some API documentation from the OpenAPI specification file.

Highlights

CaseController.java

  • Removed the casesPost method:
    • This method had been overridden and included security and authorization annotations.
    • The method's functionality to add a case was replaced by another method call.

cases.yaml

  • Deleted the following sections from the OpenAPI specification:
    • The entire post operation for adding or updating a case, which included:
      • Request body details.
      • Various response descriptions (201, 400, 404, and 500).
  • The 500 error response remains, but without the surrounding context provided by the removed post operation.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi requested review from a team as code owners March 11, 2025 15:42
@Ben-Edwards-cgi Ben-Edwards-cgi requested review from davet1985, jackmaloney, hemantasharma1129, akozichev, charlesluokb and ieuanb74 and removed request for a team March 11, 2025 15:42
@davet1985
Copy link
Contributor

Can you amend the PR title please to state that it's removing an old endpoint?

Copy link
Contributor

@davet1985 davet1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that need to be removed?

Please don't merge before hmcts/darts-gateway#716 is merged and deployed.

@hmcts-jenkins-cnp hmcts-jenkins-cnp bot requested a deployment to preview March 11, 2025 16:18 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants