feat(#859): register four High Court manual-upload flat-file cause lists - #862
Conversation
Add catalogue entries for Business & Property, Circuit Commercial Court, High Court Civil and High Court Family daily cause lists in list-type-data.ts, with co-located unit tests. These are flat-file lists (no JSON schema/validator/renderer/PDF generator). Set isNonStrategic: false so they appear in /manual-upload which accepts PDF/CSV/DOC flat files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds four High Court manual-upload flat-file daily cause list catalogue entries, with English and Welsh metadata, jurisdiction mappings, provenance, and URL paths. Adds unit tests for field values and uniqueness, alongside ticket planning, task, and review documentation. ChangesHigh Court cause list registration
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
libs/list-types/common/src/list-type-data.test.ts (2)
36-37: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUse
describe.eachfor data-driven tests.Consider using
describe.eachfrom Vitest instead of afor...ofloop. This integrates natively with the test runner for better reporting and avoids wrappingdescribeblocks in iterative loops.♻️ Proposed refactor
- for (const expected of NEW_LIST_TYPES) { - describe(expected.name, () => { + describe.each(NEW_LIST_TYPES)("$name", (expected) => {(Note: Ensure you also remove the corresponding closing brace for the
forloop at the end of the block)
56-63: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd test coverage for
defaultSensitivity.As noted in the review documentation,
defaultSensitivityis the only catalogue field on the new entries without test coverage. Consider asserting its literal value to ensure complete coverage.✅ Proposed fix
it("should have provenance CFT_IDAM", () => { // Arrange // Act const entry = listTypeData.find((item) => item.name === expected.name); // Assert expect(entry?.provenance).toBe("CFT_IDAM"); }); + + it("should have defaultSensitivity Public", () => { + // Arrange + // Act + const entry = listTypeData.find((item) => item.name === expected.name); + + // Assert + expect(entry?.defaultSensitivity).toBe("Public"); + });
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f813a3fe-cb43-485b-9a2a-117f4cb6c29d
📒 Files selected for processing (6)
docs/tickets/859/plan.mddocs/tickets/859/review.mddocs/tickets/859/tasks.mddocs/tickets/859/ticket.mdlibs/list-types/common/src/list-type-data.test.tslibs/list-types/common/src/list-type-data.ts
🎭 Playwright E2E Test Results84 tests 52 ✅ 6m 13s ⏱️ Results for commit be150e0. ♻️ This comment has been updated with latest results. |
Mirror the list-type-data.ts catalogue entries in the production seed scripts (TS seeding is skipped when ENVIRONMENT is prod). - 001_insert_missing_list_types.sql: four list_types rows - 003_upsert_sub_jurisdictions_and_list_type_links.sql: High Court (10) and Family Division (11) links Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Preview Deployment Successful 🚀Your preview environment is ready:
The environment will be automatically cleaned up when this PR is closed. |
|
Preview Deployment Successful 🚀Your preview environment is ready:
The environment will be automatically cleaned up when this PR is closed. |
1 participant
Summary
Registers four High Court manual-upload flat-file (non-strategic) cause list types in the list-type catalogue (
libs/list-types/common/src/list-type-data.ts). These are flat-file lists (PDF/CSV/DOC/HTML uploaded via the admin manual-upload journey) — they have no JSON schema, no Excel conversion, no bespoke renderer/PDF generator.Closes #859.
BUSINESS_AND_PROPERTY_DAILY_CAUSE_LISTbusiness-and-property-daily-listCIRCUIT_COMMERCIAL_COURT_DAILY_CAUSE_LISTcircuit-commercial-court-daily-listHIGH_COURT_CIVIL_DAILY_CAUSE_LISThigh-court-civil-daily-listHIGH_COURT_FAMILY_DAILY_CAUSE_LISThigh-court-family-daily-listEach entry includes English/Welsh friendly names, url path, provenance, sensitivity, and sub-jurisdiction IDs.
Changes
libs/list-types/common/src/list-type-data.ts— four new catalogue entrieslibs/list-types/common/src/list-type-data.test.ts— unit tests for the additionsdocs/tickets/859/*— ticket planning docsNote for reviewers
The committed entries use
isNonStrategic: falseanddefaultSensitivity: "Public", whereas the ticket text describesisNonStrategic: truewith empty sensitivity. Please confirm which is correct against CaTH ORG / #846 before merge (the ticket's TODO also flags confirming provenance/sensitivity/sub-jurisdiction values).Testing
yarn testacross the workspace🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Tests