feat(infra): provision Azure Blob Storage for cath-service - #748
Conversation
- Add infrastructure/storage.tf using cnp-module-storage-account@4.x
with 3 private containers (artefact, files, publications), role
assignment for cath-${env}-mi, and KV secrets for connection string
and account name (app KV + bootstrap KV)
- Add storage account variables to infrastructure/variables.tf
- Inject storageaccount-* secrets into api and web Helm values
- Add MANAGED_IDENTITY_CLIENT_ID to stg/prod and preview Helm templates
- Add Azurite blob emulator to docker-compose for local development
- Add AZURE_STORAGE_* vars to apps/web/.env.example
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 53 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🎭 Playwright E2E Test Results84 tests 52 ✅ 5m 54s ⏱️ Results for commit 9f10bcf. ♻️ This comment has been updated with latest results. |
The module expects managed_identity_object_id (principal ID) and role_assignments as list(string) of role names, not a list of objects. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Terraform Plan for
|
Terraform Plan for
|
Terraform Plan for
|
Terraform Plan for
|
Removes storageaccount-* secrets from base values.yaml files so PR/dev builds don't hang waiting for secrets that only exist after Terraform applies. Secrets are now injected via values.template.yaml (stg/prod) where the storage account will have been provisioned. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Preview Deployment Successful 🚀Your preview environment is ready:
The environment will be automatically cleaned up when this PR is closed. |
10 STATUS + IMPL changes (closed issue + merged closing PR → verified): REQ-0078 (#301): implemented → verified (PR #458) REQ-0105 (#428): in_progress → verified (PR #749) REQ-0106 (#429): approved → verified (PR #761) REQ-0107 (#431): implemented → verified (PR #701) REQ-0108 (#434): approved → verified (PR #772) REQ-0109 (#436): implemented → verified (PR #727) REQ-0112 (#467): implemented → verified (PR #670) REQ-0124 (#563): approved → verified (PR #782) REQ-0135 (#569): in_progress → verified (PR #748) REQ-0137 (#729): approved → verified (PR #766) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>



Summary
infrastructure/storage.tfusingcnp-module-storage-account@4.xwith 3 private containers (artefact,files,publications), grantscath-${env}-mitheStorage Blob Data Contributorrole, and writesstorageaccount-connection-string/storageaccount-namesecrets to both the application KV and bootstrap KV (shared-storageaccount-namein bootstrap)infrastructure/variables.tfwith pip-matching defaults (StorageV2, Standard, RAGRS, Cool)AZURE_STORAGE_CONNECTION_STRINGandAZURE_STORAGE_ACCOUNT_NAMEintoapps/api/helm/values.yamlandapps/web/helm/values.yamlvia Key Vault secret mountsMANAGED_IDENTITY_CLIENT_IDto bothvalues.template.yaml(stg/prod) andvalues.preview.template.yaml(PR builds) — dev environment reusescath-stg-miclient ID (platform ops: set as GitHub Actionsdevenvironment variable)docker-compose.ymlfor local development (port 10000)apps/web/.env.examplewith Azurite well-known connection stringCloses #569
Test plan
terraform planproduces no errors against stgMANAGED_IDENTITY_CLIENT_IDset in thedevGitHub Actions environmentdocker-compose up azuritestarts the emulator; app connects usingAZURE_STORAGE_CONNECTION_STRINGfrom.env.examplestorage.tfmatch module outputs (storageaccount_primary_connection_string,storageaccount_name) onceterraform initis run againstcnp-module-storage-account@4.x🤖 Generated with Claude Code