Skip to content

Feature 323 - Third party subscription fulfilment - current - #477

Merged
junaidiqbalmoj merged 40 commits into
masterfrom
feature/323-third-party-subscription-fulfilment
Jun 5, 2026
Merged

junaidiqbalmoj merged 40 commits into
masterfrom
feature/323-third-party-subscription-fulfilment

Merge branch 'master' into feature/323-third-party-subscription-fulfi…

81c1c8c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 5, 2026 in 57s

Annotations

Check warning on line 43 in libs/legacy-third-party-fulfilment/src/push/http-client.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrG_YNLq2w-r9Tr&open=AZ47CVrG_YNLq2w-r9Tr&pullRequest=477

Check warning on line 76 in libs/legacy-third-party-fulfilment/src/service.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrT_YNLq2w-r9Tu&open=AZ47CVrT_YNLq2w-r9Tu&pullRequest=477

Check warning on line 30 in libs/legacy-third-party-fulfilment/src/push/http-client.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrG_YNLq2w-r9Tp&open=AZ47CVrG_YNLq2w-r9Tp&pullRequest=477

Check warning on line 5 in libs/legacy-third-party-fulfilment/src/push/retry.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`SUCCESS_STATUSES` should be a `Set`, and use `SUCCESS_STATUSES.has()` to check existence or non-existence.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVl__YNLq2w-r9To&open=AZ47CVl__YNLq2w-r9To&pullRequest=477

Check warning on line 74 in libs/legacy-third-party-fulfilment/src/push/http-client.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrG_YNLq2w-r9Tt&open=AZ47CVrG_YNLq2w-r9Tt&pullRequest=477

Check warning on line 31 in libs/legacy-third-party-fulfilment/src/push/http-client.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrG_YNLq2w-r9Tq&open=AZ47CVrG_YNLq2w-r9Tq&pullRequest=477

Check warning on line 44 in libs/legacy-third-party-fulfilment/src/push/http-client.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not call `Array#push()` multiple times.

See more on https://sonarcloud.io/project/issues?id=hmcts.cath&issues=AZ47CVrG_YNLq2w-r9Ts&open=AZ47CVrG_YNLq2w-r9Ts&pullRequest=477