Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to robolectric 4 #11

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

alexwhb
Copy link

@alexwhb alexwhb commented Sep 13, 2019

Upgrades library to be compatible with Robolectric 4.0 to 4.3 and maybe future versions as well.

@antonkazakov
Copy link

antonkazakov commented Oct 29, 2019

@alexwhb hey. Thank you for your PR which enables support for new Robolectrics version, however lot of tests are failing. And the biggest problem is that when running tests separated by classes only first class will be run. Other tests will be ignored. Did you found solution to this problem? Thanks a lot.

@nrbrook
Copy link

nrbrook commented Feb 6, 2021

I forked this branch here https://github.com/nrbrook/electricspock/tree/upgrade_to_robolectric_4 and made some progress upgrading all dependencies to new versions (including JUnit to v5) and tidying up a few things. I managed to get tests to run but Roboelectric implementations aren't there, filtering doesn't work and it seems to be counting some classes as tests. To be honest it's over my head and I've sunk too much time into it already, but it would be great if this could help someone who knows this stuff better get things working.

@alexwhb
Copy link
Author

alexwhb commented Feb 6, 2021

@nrbrook That's where I ended up with it too.. it was a bit over my head as well and I had sunk way too much time into it. Looks like you did a nice job on cleaning up the code. Maybe if I get some time soon I'll dive back into it a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants