Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the logic of when to apply NaN, -Inf, and +Inf styles #117

Merged
merged 2 commits into from
May 11, 2023

Conversation

hkang1
Copy link
Owner

@hkang1 hkang1 commented May 11, 2023

Currently the NaN, -Inf, and +Inf styles are only applied when they are detected at the target dimension. They should instead be applied if any of the dimensions have the corresponding special values.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for bejewelled-lamington-f97ebd ready!

Name Link
🔨 Latest commit 7c96150
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-lamington-f97ebd/deploys/645d153d249cc10008d74024
😎 Deploy Preview https://deploy-preview-117--bejewelled-lamington-f97ebd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hkang1 hkang1 merged commit 236d2d6 into main May 11, 2023
@hkang1 hkang1 deleted the fix-nan-inf-styles branch May 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant