Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-49] add support for initializing chart with configurable filters #114

Merged
merged 17 commits into from
May 10, 2023

Conversation

hkang1
Copy link
Owner

@hkang1 hkang1 commented Apr 28, 2023

Add support for initializing charts with filters upfront via config.
Fix the filter hooks to properly return the filter positions along with the dimension key they apply to.
Provide additional styling config to customize data lines based on NaN, -Infinity, Infinity and filters.

Screen Shot 2023-05-10 at 12 19 59 AM

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for bejewelled-lamington-f97ebd ready!

Name Link
🔨 Latest commit c969a51
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-lamington-f97ebd/deploys/645b380ab66e170008702a00
😎 Deploy Preview https://deploy-preview-114--bejewelled-lamington-f97ebd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #114 (c969a51) into main (ee83e69) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   99.00%   99.60%   +0.59%     
==========================================
  Files          17       17              
  Lines        1716     1763      +47     
  Branches      586      608      +22     
==========================================
+ Hits         1699     1756      +57     
+ Misses         17        7      -10     
Impacted Files Coverage Δ
src/classes/LogScale.ts 100.00% <ø> (ø)
src/defaults.ts 100.00% <ø> (ø)
src/types.ts 100.00% <ø> (ø)
src/classes/LinearScale.ts 100.00% <100.00%> (ø)
src/classes/NiceScale.ts 100.00% <100.00%> (ø)
src/index.ts 99.25% <100.00%> (+1.11%) ⬆️
src/utils/data.ts 100.00% <100.00%> (ø)
src/utils/interaction.ts 100.00% <100.00%> (ø)
src/utils/tester.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hkang1 hkang1 force-pushed the 49-filters-io branch 2 times, most recently from 8301272 to c969a51 Compare May 10, 2023 06:21
@hkang1 hkang1 enabled auto-merge May 10, 2023 06:25
@hkang1 hkang1 disabled auto-merge May 10, 2023 06:26
@hkang1 hkang1 merged commit cb8114b into main May 10, 2023
@hkang1 hkang1 deleted the 49-filters-io branch May 10, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant