-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-49] add support for initializing chart with configurable filters #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bejewelled-lamington-f97ebd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 99.00% 99.60% +0.59%
==========================================
Files 17 17
Lines 1716 1763 +47
Branches 586 608 +22
==========================================
+ Hits 1699 1756 +57
+ Misses 17 7 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hkang1
force-pushed
the
49-filters-io
branch
2 times, most recently
from
May 10, 2023 06:21
8301272
to
c969a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for initializing charts with filters upfront via config.
Fix the filter hooks to properly return the filter positions along with the dimension key they apply to.
Provide additional styling config to customize data lines based on NaN, -Infinity, Infinity and filters.