Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-109] feat: add support for +/-Infinity and NaN numbers #112

Merged
merged 15 commits into from
Apr 24, 2023

Conversation

hkang1
Copy link
Owner

@hkang1 hkang1 commented Apr 24, 2023

Previously +/- Infinity values and NaN values were filtered out to prevent the chart from rendering properly. This update will detect +/- Infinity values and NaN values (independently) and add the appropriate axes to render them.

Screen Shot 2023-02-03 at 2 53 44 PM

Screen Shot 2023-02-03 at 2 54 33 PM

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for bejewelled-lamington-f97ebd ready!

Name Link
🔨 Latest commit ee83e69
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-lamington-f97ebd/deploys/64461a24b8d2fb0008b8d6ef
😎 Deploy Preview https://deploy-preview-112--bejewelled-lamington-f97ebd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #112 (ee83e69) into main (4226a86) will increase coverage by 0.89%.
The diff coverage is 98.60%.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   98.10%   99.00%   +0.89%     
==========================================
  Files          17       17              
  Lines        1587     1716     +129     
  Branches      533      586      +53     
==========================================
+ Hits         1557     1699     +142     
+ Misses         30       17      -13     
Impacted Files Coverage Δ
src/defaults.ts 100.00% <ø> (ø)
src/types.ts 100.00% <ø> (ø)
src/utils/tester.ts 100.00% <ø> (ø)
src/index.ts 98.14% <98.48%> (+1.93%) ⬆️
src/utils/canvas.ts 100.00% <100.00%> (ø)
src/utils/data.ts 100.00% <100.00%> (ø)
src/utils/interaction.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hkang1 hkang1 merged commit e88765b into main Apr 24, 2023
@hkang1 hkang1 deleted the 109-nan-inf-axes branch April 24, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant