Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-100] handle single negative value auto range #101

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

hkang1
Copy link
Owner

@hkang1 hkang1 commented Jun 3, 2022

In the case of a scale with only one single value, the min / max values are going to be the same. NiceScale attempts to auto determine a reasonable range. Currently it only handles when the single value is a positive value (> 0).

  • add support for the case when the single value is 0
  • add support for the case when the single value is less than 0

@netlify
Copy link

netlify bot commented Jun 3, 2022

Deploy Preview for bejewelled-lamington-f97ebd ready!

Name Link
🔨 Latest commit 7645e7d
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-lamington-f97ebd/deploys/629a7d53d16f1d0008902a94
😎 Deploy Preview https://deploy-preview-101--bejewelled-lamington-f97ebd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hkang1 hkang1 requested a review from trentwatt June 3, 2022 19:25
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #101 (7645e7d) into main (0d6e7a2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   97.97%   97.99%   +0.01%     
==========================================
  Files          17       17              
  Lines        1534     1543       +9     
  Branches      516      519       +3     
==========================================
+ Hits         1503     1512       +9     
  Misses         31       31              
Impacted Files Coverage Δ
src/classes/NiceScale.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hkang1 hkang1 mentioned this pull request Jun 3, 2022
@hkang1 hkang1 merged commit b388341 into main Jun 3, 2022
@hkang1 hkang1 deleted the 100-handle-single-negative-value-auto-range branch June 3, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NiceScale is unable to handle the case of a single negative data point to create range.
2 participants