[model] fix: stuck issue with mixed text-image data#518
Merged
hiyouga merged 1 commit intohiyouga:mainfrom Oct 4, 2025
HollowMan6:main
Merged
[model] fix: stuck issue with mixed text-image data#518hiyouga merged 1 commit intohiyouga:mainfrom HollowMan6:main
hiyouga merged 1 commit intohiyouga:mainfrom
HollowMan6:main
Conversation
Same as verl-project/verl#3670, we should revert this part of change in 35e693a, otherwise it will cause stuck again. verl-project/verl#3315 (comment) It should be pretty safe and optional to do without `model.training` checks even the model is in inference mode, as the value of `inputs_embeds` won't get modified anyway. Signed-off-by: Hollow Man <hollowman@opensuse.org>
hiyouga
pushed a commit
that referenced
this pull request
Oct 4, 2025
Signed-off-by: Hollow Man <hollowman@opensuse.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as verl-project/verl#3670, we should revert this part of change in 35e693a, otherwise it will cause stuck again.
verl-project/verl#3315 (comment)
It should be pretty safe and optional to do without
model.trainingchecks even the model is in inference mode, as the value ofinputs_embedswon't get modified anyway.