Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Workflow Updates #11

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Release Workflow Updates #11

merged 5 commits into from
Oct 27, 2020

Conversation

alexbhr
Copy link
Contributor

@alexbhr alexbhr commented Oct 24, 2020

Dear @hiyosi,

we use the hawk library internally at work for a few different services, and I wanted to start by thanking you on behalf of our whole dev team for writing hawk.

As part of ensuring the long term maintainability of various project dependencies, we decided to submit a set of Github Actions workflows to hawk that test the lib on various platforms and supported versions of Golang.

Some points about this PR:

  • It runs go vet before go test to ensure sane syntax
  • It maintains goveralls support across the matrix build of os/golang versions
  • It creates a go.mod file for modern dependency management
  • It introduces a Goreleaser trigger when new tags are pushed, which create a Github release along with a decent changelog of what changes
  • It deprecates Travis by removing the .travis.yml file

If you decide to merge this, please pull the code locally and do a git tag v1.0.0 && git push origin master --tags to trigger the Goreleaser action.

Thanks again, and greetings to Japan from all of us out here!

@hiyosi hiyosi self-requested a review October 25, 2020 23:14
@hiyosi
Copy link
Owner

hiyosi commented Oct 25, 2020

@alexbhr
Thank you so much for your contribution!
I'll review this soon.

@hiyosi hiyosi merged commit 00fa49a into hiyosi:master Oct 27, 2020
@hiyosi
Copy link
Owner

hiyosi commented Oct 28, 2020

I'd like to thank you again.
I've created tag=v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants