Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @hiyosi,
we use the hawk library internally at work for a few different services, and I wanted to start by thanking you on behalf of our whole dev team for writing hawk.
As part of ensuring the long term maintainability of various project dependencies, we decided to submit a set of Github Actions workflows to hawk that test the lib on various platforms and supported versions of Golang.
Some points about this PR:
go vet
beforego test
to ensure sane syntaxgo.mod
file for modern dependency management.travis.yml
fileIf you decide to merge this, please pull the code locally and do a
git tag v1.0.0 && git push origin master --tags
to trigger the Goreleaser action.Thanks again, and greetings to Japan from all of us out here!