Add newly messages #26
Conversation
| foreach ( $messages as $message ) { | ||
|
|
||
| // Mark as read. | ||
| $message->set_read( 1 )->save_read(); |
There was a problem hiding this comment.
Is it possible to use true/false or maybe we map this flag to a hacky field like comment_karma? Then it's ok to leave it as is
| $response = []; | ||
|
|
||
| // Set output. | ||
| $output = ''; |
There was a problem hiding this comment.
Output should be rendered only if the _render parameter is passed, because this is not the main purpose of REST actions (to render HTML), just a temporary workaround until we move to Vue.js
The action should return something (e.g. messages as arrays in "data") with an extra "html" parameter if _render is sent with the request
There was a problem hiding this comment.
this is how it already works, if you scroll down - you'll see that there is condition to check if output variable is not empty
| 'template' => 'message_view_block', | ||
|
|
||
| 'context' => [ | ||
| 'message' => Models\Message::query()->get_by_id( $message->get_id() ), |
There was a problem hiding this comment.
Why querying message again, or the initial object is not complete in some way?
There was a problem hiding this comment.
Yes, initial object sent date is NULL
No description provided.