Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone and tcpconnect tracer #28

Merged
merged 13 commits into from
Aug 31, 2023
Merged

Add clone and tcpconnect tracer #28

merged 13 commits into from
Aug 31, 2023

Conversation

WYXsb
Copy link
Contributor

@WYXsb WYXsb commented Aug 30, 2023

I added some new tracers, but I can"t end /cli/main.py by Ctrl + C.

Copy link
Contributor

@wunder957 wunder957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and well done the first PR, I'll check cli interrupting issue later.

duetector/tracers/clone.py Outdated Show resolved Hide resolved
duetector/tracers/clone.py Outdated Show resolved Hide resolved
duetector/tracers/tcpconnect.py Outdated Show resolved Hide resolved
duetector/tracers/tcpconnect.py Outdated Show resolved Hide resolved
duetector/tracers/tcpconnect.py Outdated Show resolved Hide resolved
duetector/tracers/tcpconnect.py Outdated Show resolved Hide resolved
@wunder957 wunder957 added the enhancement New feature or request label Aug 30, 2023
@wunder957 wunder957 added this to the v0.0.2 milestone Aug 30, 2023
@wunder957 wunder957 linked an issue Aug 30, 2023 that may be closed by this pull request
@wunder957 wunder957 changed the title new tracers Add clone and tcpconnect tracer Aug 30, 2023
@wunder957
Copy link
Contributor

The reason why you stuck on exiting CLI is ring_buffer_poll does not set timeout, and it just poll forever for TcpconnectTracer

I would make a commit on this pr for fixing missing timeout issue.

@wunder957
Copy link
Contributor

wunder957 commented Aug 30, 2023

TcpconnectTracer may require us to make some changes to the Tracer's API to support attatching multiple C functions to the BPF

This change should not affect the original design, but rather an advanced way

I think we can open another PR to deal with this matter

* Improve CLI and monitor on error

* Add dev-tools for debugging

* Improve debug tools and log

* Fix testing

* Improve config and check repo config uptodate
duetector/tracers/clone.py Outdated Show resolved Hide resolved
duetector/tracers/tcpconnect.py Show resolved Hide resolved
duetector/tracers/base.py Outdated Show resolved Hide resolved
@wunder957 wunder957 merged commit 516c9a4 into hitsz-ids:main Aug 31, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More tracers
3 participants