Skip to content

[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hitesh-wagento merged 4 commits into from
Jun 5, 2018
Merged

[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
402d565
MAGETWO-91958: EE install fails on 7.2.5 with fatal error
rganin May 21, 2018
d9548f8
merge magento/2.3-develop into magento-earl-grey/MAGETWO-91958
Jun 4, 2018
66abad2
Merge pull request #2638 from magento-earl-grey/MAGETWO-91958
cpartica Jun 4, 2018
9fa6425
hitesh-wagento Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/design/frontend/Magento/luma/web/css/source/_forms.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,7 @@
.select-styling() {
.lib-css(appearance, none, 1);
appearance: none;
background: @select__background url('../images/select-bg.svg') no-repeat 100% 45%;
background-size: 30px 60px;
border: 1px solid @border-color__base;
height: 32px;
padding-right: 25px;
text-indent: .01em;
text-overflow: '';

Expand Down
7 changes: 7 additions & 0 deletions app/design/frontend/Magento/luma/web/css/source/_theme.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@
// Forms
// ---------------------------------------------


// Select
@select__background: @form-element-input__background url('../images/select-bg.svg') no-repeat 100% 45%;
@select__border: 1px solid @border-color__base;
@select__height: 32px;
@select__padding: 4px 25px @indent__xs @indent__s;

// Form fieldset
@form-fieldset-legend__font-size: 18px;
@form-fieldset-legend__font-weight: @font-weight__light;
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DDLTriggerInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ public function isApplicable(string $statement) : bool ;
* @param ElementHistory $elementHistory
* @return callable
*/
public function getCallback(ElementHistory $elementHistory) : Callable;
public function getCallback(ElementHistory $elementHistory) : callable;
}
2 changes: 1 addition & 1 deletion ...nto/Framework/Setup/Declaration/Schema/Db/MySQL/DDL/Triggers/MigrateDataBetweenShards.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function isApplicable(string $statement) : bool
/**
* @inheritdoc
*/
public function getCallback(ElementHistory $elementHistory) : Callable
public function getCallback(ElementHistory $elementHistory) : callable
{
/** @var Table $newTable */
$newTable = $elementHistory->getNew();
Expand Down
2 changes: 1 addition & 1 deletion ...rnal/Magento/Framework/Setup/Declaration/Schema/Db/MySQL/DDL/Triggers/MigrateDataFrom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function isApplicable(string $statement) : bool
/**
* @inheritdoc
*/
public function getCallback(ElementHistory $columnHistory) : Callable
public function getCallback(ElementHistory $columnHistory) : callable
{
/** @var Column $column */
$column = $columnHistory->getNew();
Expand Down
2 changes: 1 addition & 1 deletion .../Framework/Setup/Declaration/Schema/Db/MySQL/DDL/Triggers/MigrateDataFromAnotherTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function isApplicable(string $statement) : bool
/**
* @inheritdoc
*/
public function getCallback(ElementHistory $tableHistory) : Callable
public function getCallback(ElementHistory $tableHistory) : callable
{
/** @var Table $table */
$table = $tableHistory->getNew();
Expand Down
2 changes: 1 addition & 1 deletion lib/web/css/source/lib/variables/_forms.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
@select__disabled__font-style: @form-element-input__disabled__font-style;

// Focus state
@select__focus__background: @form-element-input__focus__background;
@select__focus__background: false;
@select__focus__border: @form-element-input__focus__border;
@select__focus__color: @form-element-input__focus__color;
@select__focus__font-style: @form-element-input__focus__font-style;
Expand Down