[Backport] [Resolved : Styling <select> by changing less variables in Luma theme…#1
Merged
hitesh-wagento merged 1 commit into2.1-developfrom Jun 5, 2018
Merged
Conversation
hitesh-wagento
pushed a commit
that referenced
this pull request
Jun 22, 2018
…nto#15726 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026 - Merged commits: 1. ce176d2
hitesh-wagento
pushed a commit
that referenced
this pull request
Jun 22, 2018
hitesh-wagento
pushed a commit
that referenced
this pull request
Jun 22, 2018
Accepted Public Pull Requests: - magento#16275: Simplified TypeProcessor (by @joni-jones) - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento) - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento) - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento) - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch) - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade) - magento#16256: magento#15255 unlock customer after password reset (by @vgelani) - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto) - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate) - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento) - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu) Fixed GitHub Issues: - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 0f23ed7 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch Related commits: 1. 7f34b22 2. 349d178 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch Related commits: 1. ce176d2 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch Related commits: 1. a108233
hitesh-wagento
pushed a commit
that referenced
this pull request
Jun 25, 2018
Merged with last commits
hitesh-wagento
pushed a commit
that referenced
this pull request
Jun 27, 2018
[Forwardport] Fixed typo mistake in function comment
hitesh-wagento
pushed a commit
that referenced
this pull request
Jul 4, 2018
[Forwardport] When searching for the title if search for all the segments that has …
hitesh-wagento
pushed a commit
that referenced
this pull request
Jul 14, 2018
[Forwardport] Resolved : no navigation-level0-item__hover__color magento#15848
hitesh-wagento
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixed a grammatical error on the vault tooltip
hitesh-wagento
pushed a commit
that referenced
this pull request
Dec 5, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
hitesh-wagento
pushed a commit
that referenced
this pull request
Dec 5, 2018
Update 2.2 develop branch
hitesh-wagento
pushed a commit
that referenced
this pull request
Dec 31, 2018
Update 2.3 develop branch
hitesh-wagento
pushed a commit
that referenced
this pull request
Dec 31, 2018
Missing setTotalCount on $searchResults object in getList method
hitesh-wagento
pushed a commit
that referenced
this pull request
Jan 29, 2019
removes extra dot on "How to run Magento" in phpserve/README.md
hitesh-wagento
pushed a commit
that referenced
this pull request
Dec 10, 2019
merge magento:2.3-develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15734
Have "select" elements with the styles you set in _theme.less
Description
Fixed Issues (if relevant)
selectby changing less variables in Luma theme doesn't work as expectedManual testing scenarios
@select__background: rgba(255, 255, 255, 0.15);
@select__border: 2px dashed blue;
@select__height: 50px;
@select__padding: 15px 40px 15px 15px;
@select__background-clip: border-box;
Contribution checklist