Category with color #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ahaneef29 for the contribution. Can you also provide some screenshots and fix the unit tests? |
|
@saleem-hadad Updated existing test case and with sample image.
|
|
@saleem-hadad update test case, but still keep failing? |
|
I'll check |
database/migrations/2022_07_16_083805_add_color_column_in_table_categories.php
Outdated
Show resolved
Hide resolved
|
@ahaneef29 I guess the test is failing because now we have the default color is badge-gray? |
|
@saleem-hadad fixed the test cases.! Thank you for pointing out |
Yes. This is also a good place to have the default color. Co-authored-by: Saleem Hadad <[email protected]>
|
@saleem-hadad Updated as per your suggestion and all test passed |
database/migrations/2022_07_16_083805_add_color_column_in_table_categories.php
Outdated
Show resolved
Hide resolved
|
@saleem-hadad Updated |
|
Thank you very much @ahaneef29 for the hard & beautiful work. 🌹😍 |
|
@saleem-hadad Thank you very much for wonderful support. |
|
Most welcome. Now I'm thinking that we can use the categories' colors in the dashboard to make it consistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added color option feature for category title, User can choose the predefined color while creating category and also user can change the color on update as well.