Skip to content

Fix/range date picker close on select #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kritskii-A
Copy link
Contributor

Closes #642

Description

When you disable closeOnSelect on RangeDatePicker and select a value and close the Popover without closing the Popover and click the clear icon and close the Popover without reselecting the value, the value is flushed.

Current behavior (updates)

value is flushed

New behavior

value isn't flushed

Is this a breaking change (Yes/No):

No

Additional Information

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: c825286

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@yamada-ui/calendar Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hirotomoyamada hirotomoyamada self-requested a review January 16, 2024 12:50
@hirotomoyamada hirotomoyamada self-assigned this Jan 16, 2024
@hirotomoyamada
Copy link
Member

Thanks!

@hirotomoyamada hirotomoyamada merged commit 9891f4d into yamada-ui:main Jan 16, 2024
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The value are flushed when RangeDatePicker component Popover is closed
3 participants