Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed element type for Card component #578

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fixed element type for Card component #578

merged 1 commit into from
Jan 3, 2024

Conversation

hirotomoyamada
Copy link
Member

Closes #577

Description

The rendered element of the Card component is incorrect.

Current behavior (updates)

The documentation explains that the section element is rendered in the Cart component, but in reality, the div element is rendered.

New behavior

Fixed element type for Card component.

Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: e2045a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@yamada-ui/card Patch
@yamada-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hirotomoyamada hirotomoyamada self-assigned this Jan 3, 2024
@hirotomoyamada hirotomoyamada merged commit e2f4db1 into main Jan 3, 2024
5 checks passed
@hirotomoyamada hirotomoyamada deleted the fix/card/as branch January 3, 2024 02:02
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The rendered element of the Card component is incorrect
1 participant