Skip to content

Fix Avatar fallback background color #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Conversation

hirotomoyamada
Copy link
Member

Closes #543

Description

Avatar fallback style is incorrect

Current behavior (updates)

When Avatar does not load an image, fallback styles are applied, but the background is too dark, especially in dark mode.

New behavior

Updated fallback background color.

Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Dec 26, 2023

🦋 Changeset detected

Latest commit: 708575e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@yamada-ui/theme Patch
@yamada-ui/providers Patch
@yamada-ui/react Patch
@yamada-ui/test Patch
@yamada-ui/theme-tools Patch
@yamada-ui/use-media-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

illionillion
illionillion previously approved these changes Dec 27, 2023
@hirotomoyamada hirotomoyamada merged commit 655e1af into main Dec 27, 2023
@hirotomoyamada hirotomoyamada deleted the fix/avatar/fallback branch December 27, 2023 14:29
@github-actions github-actions bot mentioned this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar fallback style is incorrect
2 participants