Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unified disabled state handling across components #483

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

hirotomoyamada
Copy link
Member

Closes #482
Closes #481

Description

Ripple effect is occurring even when the element is disabled

Current behavior (updates)

Expected that the ripple effect would also be disabled when I disabled the Button component, etc., but it is not disabled internally and always occurs.

New behavior

Set isDisabled to useRipple and provide control to disable onPointerDown

Is this a breaking change (Yes/No):

No

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 6fd6874

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@yamada-ui/close-button Patch
@yamada-ui/pagination Patch
@yamada-ui/calendar Patch
@yamada-ui/button Patch
@yamada-ui/ripple Patch
@yamada-ui/tabs Patch
@yamada-ui/modal Patch
@yamada-ui/notice Patch
@yamada-ui/popover Patch
@yamada-ui/react Patch
@yamada-ui/table Patch
@yamada-ui/carousel Patch
@yamada-ui/file-button Patch
@yamada-ui/providers Patch
@yamada-ui/autocomplete Patch
@yamada-ui/menu Patch
@yamada-ui/select Patch
@yamada-ui/use-media-query Patch
@yamada-ui/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hirotomoyamada hirotomoyamada merged commit 08d603f into main Dec 19, 2023
5 checks passed
@hirotomoyamada hirotomoyamada deleted the fix/disabled-ripple-effect branch December 19, 2023 05:21
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant