Adding a supplementary explanation component with Markdown component #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2131788 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hirotomoyamada
changed the title
ShionTerunaga
changed the title
illionillion
requested changes
Nov 23, 2023
There was a problem hiding this comment.
noteの後にinfoやwarnなどを記述した場合、変換して表示するAlertコンポーネントのスタイルとアイコンを条件分岐した方が良いと思うので修正お願いしたいです。
https://qiita.com/Qiita/items/c686397e4a0f4f11683d#note---%E8%A3%9C%E8%B6%B3%E8%AA%AC%E6%98%8E
このようになります。
:::note info
インフォメーション
infoは省略可能です。
:::
:::note warn
インフォメーション
infoは省略可能です。
:::
:::note alert
インフォメーション
infoは省略可能です。
:::
条件分岐させるスタイルについてはAlertのStorybookを参考にしてください。
|
@teru12012000 新しい機能をStoryで追加してほしいです。 |
illionillion
approved these changes
Nov 23, 2023
hirotomoyamada
approved these changes
Nov 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
Description
I want to be able to use a component that displays supplementary explanations using the Markdown component props remarkPlugin.
New behavior
When write note in
Markdowncomponent, can express a supplementary explanation using Yamada UIAlertcomponent.Is this a breaking change (Yes/No):
No
Additional Information