Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: cleanup bigint #1739

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix!: cleanup bigint #1739

merged 2 commits into from
Sep 24, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Sep 17, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.57+be093cb3
e.g. npm install @stacks/[email protected]+be093cb3 --save-exact

  • refactors bigint helpers. they were using a confusing signed option, which wasn't needed for most cases.
  • this should simplify things

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:44pm

@janniks janniks changed the title fix: cleanup bigint fix!: cleanup bigint Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/common/src/utils.ts 82.35% 2 Missing and 1 partial ⚠️
packages/stacking/src/index.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks merged commit 1a3cc2f into next Sep 24, 2024
10 checks passed
@janniks janniks deleted the 07-31-fix_cleanup branch September 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @rafaelcr