Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Move more helper functions to take network parameter #1733

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix!: Move more helper functions to take network parameter #1733

merged 1 commit into from
Sep 24, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 31, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.58+76575a38
e.g. npm install @stacks/[email protected]+76575a38 --save-exact

  • Another function moving to use network instead of tx-version

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:18pm

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/cli.ts 71.42% 2 Missing ⚠️
packages/transactions/src/address.ts 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 66c2963 to f1453c6 Compare July 31, 2024 21:06
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from f1453c6 to 2fc0e3b Compare September 17, 2024 14:15
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 2fc0e3b to 8bb7a38 Compare September 17, 2024 14:35
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 8bb7a38 to 289a015 Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 289a015 to 7f780fc Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-31-fix_cleanup branch 2 times, most recently from a063175 to 6581e38 Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 7f780fc to 0bbc30e Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 0bbc30e to abf42c1 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from abf42c1 to 0128e87 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 0128e87 to 05b0dc6 Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 05b0dc6 to d0a77fd Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from d0a77fd to 315d97e Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from c8e6a27 to 519b9c7 Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-31-fix_cleanup branch 2 times, most recently from 118ba14 to ebc4fdb Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from d542e0e to ec7f074 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-31-fix_cleanup branch 2 times, most recently from 819483d to f2c2814 Compare September 17, 2024 15:07
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from 4b36157 to a1fb62a Compare September 17, 2024 15:08
@janniks janniks force-pushed the 07-31-fix_cleanup branch 2 times, most recently from 70cbc71 to 752a651 Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from a1fb62a to 670de43 Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch 2 times, most recently from 3e43f79 to 76575a3 Compare September 17, 2024 15:13
Base automatically changed from 07-31-fix_cleanup to next September 24, 2024 13:11
@janniks janniks force-pushed the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch from 76575a3 to 413f206 Compare September 24, 2024 13:12
@janniks janniks merged commit b8cbde2 into next Sep 24, 2024
7 of 8 checks passed
@janniks janniks deleted the 07-31-fix_move_more_helper_functions_to_take_network_parameter branch September 24, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocaillard hugocaillard Awaiting requested review from hugocaillard

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janniks