Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helper function to make pox-4 signer signature #1628

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Feb 8, 2024

A PR was just merged into the next branch of Stacks Core that includes a new parameter signer-sig. This is a signature that proves control/approval of the provided signer key. This PR adds a little helper function to generate the proper signed structured data that is needed for this parameter.

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 11:23pm

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (52e5a2e) 66.40% compared to head (dd5cd50) 66.39%.

Files Patch % Lines
packages/stacking/src/utils.ts 60.00% 4 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           feat/update-stacking-client-to-pox-4    #1628      +/-   ##
========================================================================
- Coverage                                 66.40%   66.39%   -0.02%     
========================================================================
  Files                                       119      119              
  Lines                                      8718     8727       +9     
  Branches                                   1920     1948      +28     
========================================================================
+ Hits                                       5789     5794       +5     
+ Misses                                     2803     2694     -109     
- Partials                                    126      239     +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!! Looks good

@janniks janniks merged commit 10a5064 into hirosystems:feat/update-stacking-client-to-pox-4 Feb 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants