Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error if the number type used in the bigint constructor is… #1527

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 5, 2023

This PR was published to npm with the version 6.5.5-pr.7b4dabf.0
e.g. npm install @stacks/[email protected] --save-exact

… not a safe integer value


Checklist

@janniks janniks linked an issue Jul 5, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 8:48pm

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1527 (7b4dabf) into main (ee4df48) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1527      +/-   ##
==========================================
- Coverage   66.16%   66.16%   -0.01%     
==========================================
  Files         118      118              
  Lines        8631     8633       +2     
  Branches     1906     1907       +1     
==========================================
+ Hits         5711     5712       +1     
- Misses       2683     2684       +1     
  Partials      237      237              
Impacted Files Coverage Δ
packages/common/src/utils.ts 41.59% <50.00%> (+0.07%) ⬆️

@janniks janniks force-pushed the 1515-uintcv-stores-wrong-number branch from 239df4c to 7b4dabf Compare July 5, 2023 20:46
@janniks janniks merged commit d6a6fcc into main Jul 6, 2023
@janniks janniks deleted the 1515-uintcv-stores-wrong-number branch July 6, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uintcv stores wrong number
2 participants