Skip to content

Commit

Permalink
chore: remove bootstrap
Browse files Browse the repository at this point in the history
  • Loading branch information
janniks committed Aug 10, 2023
1 parent 2e8f05f commit 983d9f6
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 29 deletions.
1 change: 0 additions & 1 deletion .github/workflows/publish-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:

- run: npm install -g npm@latest
- run: npm ci
- run: npm run bootstrap

- run: git config --local user.email '[email protected]'
- run: git config --local user.name 'GitHub Action'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:

- run: npm install -g npm@latest
- run: npm ci
- run: npm run bootstrap
- run: npm run build

- run: git config --local user.email '[email protected]'
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pull-request
on:
pull_request:
paths-ignore:
- "**.md"
- '**.md'

workflow_dispatch:

Expand Down Expand Up @@ -41,7 +41,6 @@ jobs:
cache: npm
- run: npm install -g npm@latest
- run: npm ci
- run: npm run bootstrap
- id: git-commit
run: echo "::set-output name=sha::$(git rev-parse --short HEAD)"
- run: echo $SHA
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,12 @@ jobs:
- run: npm install -g npm@latest
- run: npm ci

- name: Bootstrap lerna
run: npm run bootstrap

- name: Check bootstrap
- name: Check package.json
run: |
if [[ -n $(git status -s) ]]; then
git status
echo "Error: file tree is not clean; Likely needs bootstraping"
echo "Run `npm run bootstrap` and commit to resolve"
echo "Error: file tree is not clean; Likely needs npm install"
echo "Run `npm install` and commit to resolve"
exit 1
fi
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ jobs:

- run: npm install -g npm@latest
- run: npm ci
- run: npm run bootstrap

# workaround for changesets/action to allow not using changesets
# todo: add `force` option on fork to allow removing this workaround
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ To migrate your app from blockstack.js to Stacks.js follow the steps in the resp

If you encounter a bug or have a feature request, we encourage you to follow the steps below:

1. **Search for existing issues:** Before submitting a new issue, please search [existing and closed issues](../../issues) to check if a similar problem or feature request has already been reported.
1. **Open a new issue:** If it hasn't been addressed, please [open a new issue](../../issues/new/choose). Choose the appropriate issue template and provide as much detail as possible, including steps to reproduce the bug or a clear description of the requested feature.
1. **Evaluation SLA:** Our team reads and evaluates all the issues and pull requests. We are avaliable Monday to Friday and we make a best effort to respond within 7 business days.
1. **Search for existing issues:** Before submitting a new issue, please search [existing and closed issues](../../issues) to check if a similar problem or feature request has already been reported.
1. **Open a new issue:** If it hasn't been addressed, please [open a new issue](../../issues/new/choose). Choose the appropriate issue template and provide as much detail as possible, including steps to reproduce the bug or a clear description of the requested feature.
1. **Evaluation SLA:** Our team reads and evaluates all the issues and pull requests. We are avaliable Monday to Friday and we make a best effort to respond within 7 business days.

Please **do not** use the issue tracker for personal support requests or to ask for the status of a transaction. You'll find help at the [#support Discord channel](https://discord.gg/SK3DxdsP).

Expand All @@ -64,17 +64,17 @@ To setup the development environment for this repository, follow these steps:
> NodeJS & npm are required (v18.x.x is currently recommended)
1. Clone this package.
2. Run `npm install` to install dependencies
3. Run `npm run bootstrap` to [bootstrap](https://github.com/lerna/lerna/tree/main/commands/bootstrap) project
4. Run `npm run build` to build packages
5. Run `npm run test` to run tests
1. Run `npm install` to install dependencies
1. Run `npm run build` to build packages
1. Run `npm run test` to run tests

> Some tests may contain logging of errors and warnings.
> This should not be confused with failing tests.
> Make sure the last lines of `npm run test` show `lerna success - @stacks/...` for every package.
### Code of Conduct
Please read our [Code of conduct](../../../.github/blob/main/CODE_OF_CONDUCT.md) since we expect project participants to adhere to it.

Please read our [Code of conduct](../../../.github/blob/main/CODE_OF_CONDUCT.md) since we expect project participants to adhere to it.

## Community

Expand Down
9 changes: 1 addition & 8 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,5 @@
"access": "public"
},
"changelogPreset": "conventionalcommits",
"packages": ["packages/*"],
"command": {
"bootstrap": {
"forceLocal": true,
"hoist": true,
"npmClientArgs": ["--ci"]
}
}
"packages": ["packages/*"]
}
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
"license": "MIT",
"prettier": "@stacks/prettier-config",
"scripts": {
"bootstrap": "lerna bootstrap",
"build": "lerna run build",
"build:docs": "rimraf docs && typedoc",
"ci:version": "npx lerna version --conventional-commits --no-push --no-git-tag-version --yes && npx lerna bootstrap",
"ci:version": "npx lerna version --conventional-commits --no-push --no-git-tag-version --yes",
"clean": "lerna clean",
"lerna": "lerna",
"lint": "npm run lint:eslint && npm run lint:prettier",
Expand Down

0 comments on commit 983d9f6

Please sign in to comment.