Skip to content

Conversation

@a3slade
Copy link
Contributor

@a3slade a3slade commented Jan 9, 2023

Implements part of #158
This adds the functions to the contract but does not implement the backend that gathers the signatures.
These functions do not have tests since the backend is not implemented yet.

@a3slade a3slade requested a review from obycode January 9, 2023 19:06
@a3slade a3slade mentioned this pull request Jan 9, 2023
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #195 (d66c1d7) into master (54c653c) will decrease coverage by 8.28%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   91.19%   82.92%   -8.28%     
==========================================
  Files           6        6              
  Lines         284      363      +79     
==========================================
+ Hits          259      301      +42     
- Misses         25       62      +37     
Impacted Files Coverage Δ
core-contracts/contracts/helper/simple-ft.clar 76.47% <ø> (ø)
...contracts/contracts/helper/simple-nft-no-mint.clar 66.66% <ø> (ø)
core-contracts/contracts/helper/simple-nft.clar 73.33% <ø> (ø)
core-contracts/contracts/multi-miner.clar 47.14% <ø> (-49.92%) ⬇️
core-contracts/contracts/subnet.clar 94.75% <ø> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kantai kantai self-requested a review January 19, 2023 17:13
@kantai kantai self-assigned this Feb 6, 2023
@obycode obycode force-pushed the multiminer_register_assets_2 branch from 7cb0640 to b861155 Compare February 17, 2023 01:50
@obycode obycode changed the base branch from master to mint-with-trait February 17, 2023 01:51
@obycode obycode force-pushed the mint-with-trait branch 2 times, most recently from 2e40b5d to 4a629c5 Compare February 19, 2023 00:24
Base automatically changed from mint-with-trait to master February 19, 2023 01:44
@obycode obycode force-pushed the multiminer_register_assets_2 branch from 005059a to 9c7be21 Compare February 19, 2023 01:47
@obycode obycode requested a review from jbencin February 20, 2023 19:56
@obycode obycode force-pushed the multiminer_register_assets_2 branch from 628308d to 57cd7e5 Compare February 24, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants