Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom chain ID in JS scripts #49

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Oct 14, 2024

Set STACKS_CHAIN_ID to override JS-driven transaction's chain ID, which is required when using a custom network. Defaults to the testnet chain ID otherwise.

Also updated the docker compose file for the latest develop, which required removing some (invalid) config fields from the Stacks config file.

@hstove hstove requested a review from obycode October 14, 2024 23:40
docker-compose.yml Outdated Show resolved Hide resolved
@hstove hstove requested a review from obycode October 15, 2024 14:23
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hstove hstove merged commit b457877 into main Oct 16, 2024
2 of 3 checks passed
@hstove hstove deleted the fix/custom-chain-id branch October 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants