Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-an-nft-marketplace.mdx #680

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update build-an-nft-marketplace.mdx #680

merged 2 commits into from
Jul 1, 2024

Conversation

max-crawford
Copy link
Contributor

updated copy on the NFT marketplace.

Two flags for Ryan:

The final cards need fixes.

One leads to a 404.
The other references "Clerk" and I have no idea what that is

What should we lead devs to instead here? The other guides?

Description

Describe the changes that were made in this pull request. When possible start with the motivations behind the change. Be sure to also include the following information:

  1. Motivation for change?
  2. What was changed?
  3. Link to relevant issues?

Checklist

  • Conventional commits were used
  • New links to files and images were verified
  • For fixes/refactors: all existing references were identified and replaced
  • Style guide was reviewed and applied
  • Clear code samples were provided
  • People were tagged for review

updated copy on the NFT marketplace.

Two flags for Ryan:

The final cards need fixes.

One leads to a 404.
The other references "Clerk" and I have no idea what that is

What should we lead devs to instead here? The other guides?
@max-crawford max-crawford requested a review from ryanwaits July 1, 2024 18:32
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-systems-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:11pm

Copy link
Collaborator

@ryanwaits ryanwaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated the next steps cards, approved

@ryanwaits ryanwaits merged commit 7279f9b into main Jul 1, 2024
4 checks passed
@ryanwaits ryanwaits deleted the max-crawford-patch-2 branch July 1, 2024 20:05
@ryanwaits ryanwaits self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants