Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgrade devnet #1384

Merged
merged 13 commits into from
Mar 22, 2024
Merged

Feat/upgrade devnet #1384

merged 13 commits into from
Mar 22, 2024

Conversation

hugocaillard
Copy link
Collaborator

@hugocaillard hugocaillard commented Mar 20, 2024

Description

Fixes: #1379

wip

@hugocaillard hugocaillard self-assigned this Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 751 lines in your changes are missing coverage. Please review.

Project coverage is 40.87%. Comparing base (05c6a57) to head (ff289e8).

Files Patch % Lines
components/stacks-network/src/orchestrator.rs 0.00% 482 Missing ⚠️
...omponents/stacks-network/src/chains_coordinator.rs 0.00% 217 Missing ⚠️
components/stacks-network/src/event.rs 0.00% 28 Missing ⚠️
components/clarinet-files/src/network_manifest.rs 0.00% 8 Missing ⚠️
components/stacks-network/src/ui/app.rs 0.00% 7 Missing ⚠️
components/stacks-network/src/ui/mod.rs 0.00% 4 Missing ⚠️
components/stacks-network/src/ui/ui.rs 0.00% 4 Missing ⚠️
components/stacks-network/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   41.43%   40.87%   -0.57%     
==========================================
  Files          87       87              
  Lines       32102    32556     +454     
==========================================
+ Hits        13303    13307       +4     
- Misses      18799    19249     +450     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugocaillard hugocaillard marked this pull request as ready for review March 22, 2024 16:33
MicaiahReid
MicaiahReid previously approved these changes Mar 22, 2024
components/stacks-network/src/orchestrator.rs Outdated Show resolved Hide resolved
@MicaiahReid
Copy link
Contributor

My main concern is - do we want to disable the signer if use_nakamoto = false? Has this been tested with nakamoto disabled?

@hugocaillard
Copy link
Collaborator Author

@MicaiahReid

My main concern is - do we want to disable the signer if use_nakamoto = false? Has this been tested with nakamoto disabled?

Ah yes, I might have forgot to do that 🤔
Will do.

Testing with nakamoto disabled is part of the release playbook so I was about to 👍

@hugocaillard hugocaillard merged commit 7c201d4 into main Mar 22, 2024
19 checks passed
@hugocaillard hugocaillard deleted the feat/upgrade-devnet branch March 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update stacks-node and add stacks-signer
2 participants