Use the SCAN_FLAGS_NO_TRYCATCH flag when invoking YARA from ScanMem
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the following changes.: * The `Error` code now has a `Code` field that exposes the YARA API error code to Go users, and also exposes the error codes as constants that can be used in Go code (example: `err.Code == yara.ERROR_TIMEOUT`). Sometimes is useful to get a numeric error code instead of a text string. * When `Error` is converted to a string, it includes the name of the rule causing the error. For example, instead of getting an error like `syntax error, unexpected identifier, expecting <condition>`, you get `rule \"foo\": syntax error, unexpected identifier, expecting <condition>`.
By default YARA installs an exception handler that captures SIGBUS and SIGSEGV signals during the time a scan is active. This has the purpose of capturing signals that can occur while reading from memory mapped files. However, this is a process-wide exception handler that seems to interfere with Golang's ability to detect null pointer accesses and produce memory dumps. We have seen in production cases in which a Golang process that uses YARA enters an state in which the process does nothing but doesn't crash. We suspect it is somewhat related to the exception handler installed by YARA. As a temporary measure this patch disables the installation of the exception handler during calls to `ScanMem`. Installing such handler doesn't make sense while scanning memory that is not backed by a mmaped filed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default YARA installs an exception handler that captures SIGBUS and SIGSEGV signals during the time a scan is active. This has the purpose of capturing signals that can occur while reading from memory mapped files. However, this is a process-wide exception handler that seems to interfere with Golang's ability to detect null pointer accesses and produce memory dumps.
We have seen in production cases in which a Golang process that uses YARA enters an state in which the process does nothing but doesn't crash. We suspect it is somewhat related to the exception handler installed by YARA.
As a temporary measure this patch disables the installation of the exception handler during calls to
ScanMem. Installing such handler doesn't make sense while scanning memory that is not backed by a mmaped filed.