Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom env doc to match gym API #597

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Update custom env doc to match gym API #597

merged 5 commits into from
Dec 4, 2019

Conversation

jkterry1
Copy link

@jkterry1 jkterry1 commented Dec 3, 2019 •
edited
Loading

Description
Motivation and Context
Closes #596
Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have ensured pytest and pytype both pass.

@araffin araffin added the PR template not filled Please fill the pull request template label Dec 3, 2019
@araffin
Copy link
Collaborator

araffin commented Dec 3, 2019

Thanks for the PR but please fill the PR template

@jkterry1
Copy link
Author

jkterry1 commented Dec 3, 2019

Done in edit

@araffin araffin removed the PR template not filled Please fill the pull request template label Dec 3, 2019
@jkterry1
Copy link
Author

jkterry1 commented Dec 4, 2019

Do you need anything else from me to merge this?

@araffin
Copy link
Collaborator

araffin commented Dec 4, 2019

I give you a hint: there are required fields in the PR template ;) (that's also why we ask contributors to fill it)

@jkterry1
Copy link
Author

jkterry1 commented Dec 4, 2019

Done, sorry.

araffin
araffin previously approved these changes Dec 4, 2019
View reviewed changes
Copy link
Collaborator

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@araffin araffin changed the title Update to use new close API Update custom env doc to match gym API Dec 4, 2019
@araffin araffin merged commit aaf9f41 into hill-a:master Dec 4, 2019
@jkterry1 jkterry1 mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araffin araffin araffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small error in custom environment documentation
2 participants
@jkterry1 @araffin