Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPO cpp project #585

Merged
merged 7 commits into from
Nov 28, 2019
Merged

Conversation

Antymon
Copy link

@Antymon Antymon commented Nov 26, 2019

Adding personal project dependant on Stable Baselines to the docs (link).

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

closes #513

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have ensured pytest and pytype both pass.

@araffin
Copy link
Collaborator

araffin commented Nov 26, 2019

Hello,
Thanks for the PR, please don't forget the changelog.
Btw, it seems that this is related to #513 , so you can also update this section of the doc ;)

@araffin araffin changed the title Ppo cpp project addition request PPO cpp project Nov 26, 2019
@Antymon
Copy link
Author

Antymon commented Nov 26, 2019

Oh, I could expand that section on C++, but it would quickly boil down to saying it will require some work of you if you want to do it and pointing at my work as an example.

@araffin
Copy link
Collaborator

araffin commented Nov 26, 2019

Oh, I could expand that section on C++, but it would quickly boil down to saying it will require some work of you if you want to do it and pointing at my work as an example.

Sounds good, this is only meant to provide starter material (not complete tutorial) for someone who wants to export his model to C++.

@Antymon
Copy link
Author

Antymon commented Nov 28, 2019

I resolved changelog conflicts.
I understand that C++ portability suggestions are out of scope of this PR.

@araffin
Copy link
Collaborator

araffin commented Nov 28, 2019

Please still put a link to your project in the export model section ;) (plus one or two sentences)

@Antymon
Copy link
Author

Antymon commented Nov 28, 2019

Here you go.

Copy link
Collaborator

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merci beaucoup =) (those kind of contribution are really helpful)

@araffin araffin merged commit 04c35e1 into hill-a:master Nov 28, 2019
@araffin
Copy link
Collaborator

araffin commented Nov 28, 2019

I bypassed Codacy because no changes to the code were made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Exporting trained agent into c/c++ code
2 participants