Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substructures: constructor fails for non-Float32 atom containers #150

Closed
tkemmer opened this issue Dec 17, 2024 · 0 comments · Fixed by #151
Closed

Substructures: constructor fails for non-Float32 atom containers #150

tkemmer opened this issue Dec 17, 2024 · 0 comments · Fixed by #151
Assignees
@tkemmer
Labels
bug Something isn't working
Milestone
v0.4

Comments

@tkemmer
Copy link
Collaborator

tkemmer commented Dec 17, 2024

BiochemicalAlgorithms.jl/src/substructures/substructure.jl

Line 30 in 0dfae5a

) where {T, A} = Substructure{Float32, typeof(parent)}(name, parent, atoms, bonds, properties)

Explicitly using Float32 restricts T to the same type.
@tkemmer tkemmer added the bug Something isn't working label Dec 17, 2024
@tkemmer tkemmer added this to the v0.4 milestone Dec 17, 2024
@tkemmer tkemmer self-assigned this Dec 17, 2024
@tkemmer tkemmer mentioned this issue Dec 17, 2024
Merged
@tkemmer tkemmer linked a pull request Dec 17, 2024 that will close this issue
Substructure fixes #151
Merged
tkemmer added a commit that referenced this issue Dec 17, 2024
@tkemmer
Substructures: fix Substructure ctor for non-Float32 atom containers
5702f45 
Fixes: #150
Signed-off-by: Thomas Kemmer <[email protected]>
jeleclaire pushed a commit that referenced this issue Dec 19, 2024
@tkemmer @jeleclaire
Substructures: fix Substructure ctor for non-Float32 atom containers
2a0291d 
Fixes: #150
Signed-off-by: Thomas Kemmer <[email protected]>
jeleclaire pushed a commit that referenced this issue Dec 30, 2024
@tkemmer @jeleclaire
Substructures: fix Substructure ctor for non-Float32 atom containers
d0e1235 
Fixes: #150
Signed-off-by: Thomas Kemmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkemmer tkemmer

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Substructure fixes hildebrandtlab/BiochemicalAlgorithms.jl
1 participant
@tkemmer