Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AuditLog event types #1991

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

syncblaze
Copy link
Contributor

Summary

I've noticed there are missing event types in the AuditLogEventType class, so i added them

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Copy link
Contributor

@tandemdude tandemdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the onboarding and home settings ones and whether they should be addressed in a PR adding actual support for their features instead or not.

hikari/audit_logs.py Outdated Show resolved Hide resolved
hikari/audit_logs.py Outdated Show resolved Hide resolved
@syncblaze
Copy link
Contributor Author

I understand your thinking on adressing them in their own PR but for example im working privatly on a bot which keeps track on specific audit log events, and for that I dont need to have the onboarding or home settings features implemented. I just need the AuditLogEventType. I've already handled these cases diffrently in my project, I just want to give an example on why it might still be a good idea to add them now.

@davfsa davfsa added the enhancement New feature or request label Aug 3, 2024
@davfsa davfsa changed the title Added missing AuditLog event types Add missing AuditLog event types Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants