Skip to content

Fix language prop being ignored #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshgoebel merged 2 commits into from
Dec 8, 2022
Merged

Fix language prop being ignored #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4bb191
Fix language prop being ignored
barrycohen Dec 7, 2022
c85bdc5
Update CHANGELOG.md
barrycohen Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.1.3

- Fix `language` prop being ignored unless `autodetect` is explicitly set to `false` (#41)

## 2.1.2

- Default to `tabindex="0"` on the internal `<code>` element to allow keyboard scrolling when a scrollbar is applied to the element. This resolves an accessibility issue found by Vue-Axe. (#33)
Expand Down
2 changes: 1 addition & 1 deletion src/vue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const component = defineComponent({
language.value = newLanguage
})

const autodetect = computed(() => props.autodetect || !language.value)
const autodetect = computed(() => props.autodetect && !language.value)
const cannotDetectLanguage = computed(() => !autodetect.value && !hljs.getLanguage(language.value))

const className = computed((): string => {
Expand Down