Minor change to TypeScript types and TypeScript-specific keywords #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor TypeScript primitive types addition and removal of "typedef" TypeScript-specific keyword. There is no such keyword as "typedef".
"enum" is not a type in TypeScript, but it is, indeed, a TypeScript-specific keyword. Also added "keyof" to TypeScript-specific keywords list.
joshgoebel
reviewed
Jan 21, 2022
src/languages/typescript.js
Outdated
Comment on lines
26
to
27
| "null", | ||
| "undefined", |
Member
There was a problem hiding this comment.
These are already included in ECMAScript literals.
joshgoebel
reviewed
Jan 21, 2022
src/languages/typescript.js
Outdated
| "readonly" | ||
| "readonly", | ||
| "enum", | ||
| "keyof" |
Member
There was a problem hiding this comment.
keyof is not a keyword, it's a contextual keyword, so I'm not sure we should add it. I feel like this has come up before but the only thing I could find quickly was 3403.
Our general policy is that false negatives are worse than simply not highlighting something at all.
Removed "null" and "undefined" from types list and context-based "keyof" keyword. Added "override" TS-specific keyword and "unknown" TypeScript type.
joshgoebel
approved these changes
Jan 21, 2022
Member
joshgoebel
left a comment
joshgoebel
left a comment
There was a problem hiding this comment.
Awesome, now please just add a changelog entry.
Member
|
@anydonym Thanks so much! |
wkania
pushed a commit
to wkania-forks/highlight.js
that referenced
this pull request
Jan 29, 2022
…ghlightjs#3466) - Minor TypeScript primitive types addition and removal of "typedef" TypeScript-specific keyword. There is no such keyword as "typedef". - "enum" is not a type in TypeScript, but it is, indeed, a TypeScript-specific keyword. - Added "override" TS-specific keyword and "unknown" TypeScript type.
brainlid
added a commit
to brainlid/highlight.js
that referenced
this pull request
Feb 11, 2022
* master: (816 commits) (chore) add sideEffects: false to enable tree-shaking in esbuild & others fix(markdown) Handle `***Hello world***` without breaking (highlightjs#3457) (chore) DRY up php grammar just a little enh(php) support CSSCase attribute naming refactor, security issues enh(php) Add support for Attributes fix(java) prevent false variable init on `else` (highlightjs#3455) (ci) min change threshold for size report (highlightjs#3401) (themes) Add `tokyo-night-dark` (highlightjs#3467) enh(llvm) Improve number support, add `char.escape` (highlightjs#3471) (chore) simplify brainfuck grammar fix(brainfuck) fix highlighting of initial ++/-- Minor change to TypeScript types and TypeScript-specific keywords (highlightjs#3466) fix(angelscript) Fix highlighting of int8, int16, int32, int64 (highlightjs#3464) enh(php) named arguments and fix php constants (highlightjs#3459) themes: add new felipec theme (highlightjs#3441) (chore) release 10.4.0 enh(arcade) Add missing keywords for Arcade v1.16 chore(arcade) eslint --fix, explode keywords enh(php) Left and right-side of double colon (highlightjs#3422) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically some minor modifications to the current TypeScript types and TypeScript-specific keywords list.
Changes
override, moveenumto and removetypedefTypeScript-specific keywords list.unknown,symbolandbigint.Checklist
CHANGES.md