Skip to content

enh(nsis) Update defines pattern #3417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 3, 2021
Merged

enh(nsis) Update defines pattern #3417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4fcb0d9
enh(nsis) Update defines pattern
idleberg Dec 3, 2021
dc5f6ab
Update CHANGES.md
idleberg Dec 3, 2021
21b2853
Update CHANGES.md
joshgoebel Dec 3, 2021
4cb23c8
fix: indent changelog correctly
idleberg Dec 3, 2021
b070f22
fix: add missing markdown link
idleberg Dec 3, 2021
d263421
Update CHANGES.md
joshgoebel Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Grammars:
- enh(swift) add SE-0290 unavailability condition (#3382) [Bradley Mackey][]
- fix(fsharp) Highlight operators, match type names only in type annotations, support quoted identifiers, and other smaller fixes. [Melvyn Laïly][]
- enh(java) add `sealed` and `non-sealed` keywords (#3386) [Bradley Mackey][]
- enh(nsis) Update defines pattern to allow `!` (#3417) [idleberg][]
- fix(clojure) Several issues with Clojure highlighting (#3397) [Björn Ebbinghaus][]
- fix(clojure) `comment` macro catches more than it should (#3395)
- fix(clojure) `$` in symbol breaks highlighting
Expand All @@ -31,7 +32,7 @@ Themes:
[Björn Ebbinghaus]: https://github.com/MrEbbinghaus
[Josh Goebel]: https://github.com/joshgoebel
[Samia Ali]: https://github.com/samiaab1990

[idleberg]: https://github.com/idleberg

## Version 11.3.1

Expand Down
2 changes: 1 addition & 1 deletion src/languages/nsis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export default function(hljs) {
const DEFINES = {
// ${defines}
className: 'variable',
begin: /\$+\{[\w.:-]+\}/
begin: /\$+\{[\!\w.:-]+\}/
};

const VARIABLES = {
Expand Down