Skip to content

Conversation

@bradleymackey
Copy link
Contributor

@bradleymackey bradleymackey commented Nov 13, 2021

This will report the gzip'd size of the CDN build output on every pull request, being run via GitHub actions.
Currently is applied to all Javascript output files.

Changes

Checklist

  • Markup tests not needed
  • Updated the changelog at CHANGES.md

This will report the gzip'd size of the CDN build output on every pull
request, being run via GitHub actions.
@bradleymackey bradleymackey changed the title (chore) add gzip compression action (chore) add gzip size compression report Nov 13, 2021
@joshgoebel
Copy link
Member

Can we have just a list vs wildcard? I think what we'd want indivdually:

  • /*.min.js
  • /es/*.min.js

And perhaps also (and only if the wildcard is aggregated):

  • /languages/*.min.js
  • /es/languages/*.min.js

Thoughts?

@bradleymackey
Copy link
Contributor Author

bradleymackey commented Nov 14, 2021

I think that can be done with the following wildcard: ./build/{*.min.js,es/*.min.js,languages/*.min.js,es/languages/*.min.js}.

But yes, sensible I think to only run the size of the minified files.

@bradleymackey
Copy link
Contributor Author

Yep it seems to work. See here for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Add reporting the size of build changes on PRs

2 participants