Skip to content

fix(python) def, class keywords detected mid-identifier #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2021
Merged

fix(python) def, class keywords detected mid-identifier #3381

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56981f5
fix(python) `def`, `class keywords detected mid-identifier
joshgoebel Nov 1, 2021
1e190e2
Merge branch 'main' into python_def
joshgoebel Nov 1, 2021
f4a6b32
Merge branch 'main' into python_def
joshgoebel Nov 16, 2021
1b73907
changelog
joshgoebel Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/languages/python.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ export default function(hljs) {
hljs.HASH_COMMENT_MODE,
{
match: [
/def/, /\s+/,
/\bdef/, /\s+/,
IDENT_RE,
],
scope: {
Expand All @@ -397,14 +397,14 @@ export default function(hljs) {
variants: [
{
match: [
/class/, /\s+/,
/\bclass/, /\s+/,
IDENT_RE, /\s*/,
/\(\s*/, IDENT_RE,/\s*\)/
],
},
{
match: [
/class/, /\s+/,
/\bclass/, /\s+/,
IDENT_RE
],
}
Expand Down
5 changes: 5 additions & 0 deletions test/markup/python/false_positives.expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
foo = _undef
bar

booger = _unclass
burger
5 changes: 5 additions & 0 deletions test/markup/python/false_positives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
foo = _undef
bar

booger = _unclass
burger