-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(parser) new highlightAll() API #2962
Merged
joshgoebel
merged 9 commits into
highlightjs:master
from
joshgoebel:new_highlight_all_api
Jan 19, 2021
Merged
(parser) new highlightAll() API #2962
joshgoebel
merged 9 commits into
highlightjs:master
from
joshgoebel:new_highlight_all_api
Jan 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
changed the title
<!--- Provide a general summary of your changes in the Title above -->
(parser) new highlightAll() API
Jan 14, 2021
egor-rogov
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing!
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #2277.
Changes
Added new
highlightAll()
API which deprecates:These are slated to be removed with version 12. (with v11 they will likely just because aliases to
highlightAll()
)The new function can be called at any time and will "just work".
highlight.
If there are any cases where
highlightAll()
is needed prior to the DOMonload
firing, we can discuss those cases between now and v12. That would seem to be an edge case though I'd guess and could easily be handled with a custom unload handler.Checklist
CHANGES.md
AUTHORS.txt
, under Contributors