Bump rubocop from 0.86.0 to 1.13.0#727
Closed
dependabot[bot] wants to merge 36 commits intohandon-productionfrom
Closed
Bump rubocop from 0.86.0 to 1.13.0#727dependabot[bot] wants to merge 36 commits intohandon-productionfrom
dependabot[bot] wants to merge 36 commits intohandon-productionfrom
Conversation
…on#14800) * Do not serve account actors at all in limited federation mode When an account is fetched without a signature from an allowed instance, return an error. This isn't really an improvement in security, as the only information that was previously returned was required protocol-level info, and the only personal bit was the existence of the account. The existence of the account can still be checked by issuing a webfinger query, as those are accepted without signatures. However, this change makes it so that unallowed instances won't create account records on their end when they find a reference to an unknown account. The previous behavior of rendering a limited list of fields, instead of not rendering the actor at all, was in order to prevent situations in which two instances in Authorized Fetch mode or Limited Federation mode would fail to reach each other because resolving an account would require a signed query… from an account which can only be fetched with a signed query itself. However, this should now be fine as fetching accounts is done by signing on behalf of the special instance actor, which does not require any kind of valid signature to be fetched. * Fix tests
…sts (mastodon#14479) * Add tests * Fix handling of Reject Follow when a matching follow relationship exists Regression from mastodon#12199
There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix mastodon#14091
) * Change content-type to be always computed from file data Restore previous behavior, detecting the content-type isn't very expensive, and some instances may serve files as application/octet-stream regardless of their true type, making fetching media from them fail, while it used to work pre-3.2.0. * Add test
* Fix contrast calculation for thumbnail color extraction Luminance calculation was using 0-255 RGB values instead of 0-1 sRGB values, leading to incorrectly-computed contrast values. Since we use ColorDiff already, just use its XYZ colorspace conversion code to get the value. * Require at least 3:1 contrast for both accent and foreground colors * Lower required contrast for the accent color
* Add support for inlined objects in activity audience * Add tests
…#14471) * use custom private boost icon for detail status * only use className
…odon#14656) Follow-up to mastodon#14359 In the case of limited toots, the receiver may not be explicitly part of the audience. If a specific user's inbox URI was specified, it makes sense to dereference the toot from the corresponding user, instead of trying to find someone in the explicit audience.
* Add support for latest HTTP Signatures spec draft https://www.ietf.org/id/draft-ietf-httpbis-message-signatures-00.html - add support for the “hs2019” signature algorithm (assumed to be equivalent to RSA-SHA256, since we do not have a mechanism to specify the algorithm within the key metadata yet) - add support for (created) and (expires) pseudo-headers and related signature parameters, when using the hs2019 signature algorithm - adjust default “headers” parameter while being backwards-compatible with previous implementation - change the acceptable time window logic from 12 hours surrounding the “date” header to accepting signatures created up to 1 hour in the future and expiring up to 1 hour in the past (but only allowing expiration dates up to 12 hours after the creation date) This doesn't conform with the current draft, as it doesn't permit accounting for clock skew. This, however, should be addressed in a next version of the draft: httpwg/http-extensions#1235 * Add additional signature requirements * Rewrite signature params parsing using Parslet * Make apparent which signature algorithm Mastodon on verification failure Mastodon uses RSASSA-PKCS1-v1_5, which is not recommended for new applications, and new implementers may thus unknowingly use RSASSA-PSS. * Add workaround for PeerTube's invalid signature header The previous parser allowed incorrect Signature headers, such as those produced by old versions of the `http-signature` node.js package, and seemingly used by PeerTube. This commit adds a workaround for that. * Fix `signature_key_id` raising an exception Previously, parsing failures would result in `signature_key_id` being nil, but the parser changes made that result in an exception. This commit changes the `signature_key_id` method to return `nil` in case of parsing failures. * Move extra HTTP signature helper methods to private methods * Relax (request-target) requirement to (request-target) || digest This lets requests from Plume work without lowering security significantly.
- 検索クエリを分かち書きを行わない言語に最適化 - 形態素解析を行うためにElasticsearch側にkuromojiを導入 - 検索結果をマッチ度順ではなく日付順に変更
- 投票作成時，その選択肢の数の上限を4から16に変更 - 投票作成時，その有効期限をより細かく設定出来るように変更
- Announcement機能をマージ（lindwurm/mastodon）
- 元々導入していたhotaさんのannouncements機能と，本家announcements機能において，CSSのみ競合が発生 - class名が両方とも「announcements」となっており重複していた - 元々のannouncementsの方を「announcements2」に変更
- ユニークユーザ5人以上で選出されるものを2人以上で選出されるよう変更
- カスタム絵文字としてユーザのアイコンが使える機能 - 対象はトゥート，投票の選択肢，お知らせ，アカウントプロフィール欄 - 自サーバの人が他サーバのアカウントのプロフィール絵文字を使うことはできる - 他サーバの人がプロフィール絵文字を使うことはできない
- 投稿に，文字の投稿が含まれず，かつカスタム絵文字が1つだけの場合に特大表示(7em)する - それに伴ってカスタム絵文字が段落に1つしか含まれない場合にちょっと大きく表示(4em)する機能は削除
- InstanceTickerを有効にするテーマの場合，はんドンクラブのティッカーは非表示にしていた - これまでは適用範囲がHTL/FTL/LTLのみだったが，今回それに加えてnotificationも追加した
Bumps [rubocop](https://github.com/rubocop/rubocop) from 0.86.0 to 1.13.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.86.0...v1.13.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
highemerly
force-pushed
the
handon-production
branch
from
fb4a8f8 to
6fc87e3
Compare
Author
|
Looks like rubocop is up-to-date now, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 0.86.0 to 1.13.0.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
76bc0a0Cut 1.13be91a13Update Changelogad11b07Tweak a changelog entrycd3db12Fix an incorrect auto-correct forStyle/MethodCallWithArgsParenthesesbc6f98bAdd --no-parallel command-line option (#9640)fe934c2[Fix #9636] Resolve symlinks when excluding directories9c36847Fix an incorrect auto-correct forStyle/HashConversionc53803b[Fix #9689] Treat parens around array items the same for children and deeper ...6136239Fix typosbd27fcb[Fix #5576] Treat relativity of Include parameters correctlyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)